Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create chart plugins and metadata #6072

Merged
merged 12 commits into from Oct 12, 2018
Merged

Conversation

kristw
Copy link
Contributor

@kristw kristw commented Oct 10, 2018

  • Define metadata and ChartPlugin for all the simple charts.
  • Copy thumbnail images to visualization directories and refer to them in metadata.
  • Update webpack rules to reduce limit for including image as data url via url-loader from 100KB to 10KB
  • Also change the image output format from default [hash].[ext] to [name].[hash:8].[ext]
  • Combine webpack rules for gif and jpg

This PR does not include nvd3, deck.gl or BigNumber yet

@williaster @conglei @graceguo-supercat @michellethomas

@codecov-io
Copy link

codecov-io commented Oct 11, 2018

Codecov Report

Merging #6072 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #6072   +/-   ##
=======================================
  Coverage   77.59%   77.59%           
=======================================
  Files          47       47           
  Lines        9496     9496           
=======================================
  Hits         7368     7368           
  Misses       2128     2128

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9b4cf85...ed63e8f. Read the comment docs.

Copy link
Contributor

@williaster williaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@williaster williaster merged commit 5282f39 into apache:master Oct 12, 2018
@kristw kristw deleted the kristw-meta branch October 12, 2018 06:10
bipinsoniguavus pushed a commit to ThalesGroup/incubator-superset that referenced this pull request Dec 26, 2018
* add credit field

* change image size limit for url-loader

* create chord ChartPlugin

* Update config to include original file name in the output

* add calendar

* add country map

* add eventflow

* add thumbnails

* add eventflow, filterbox, force-directed and heatmap

* Add histogram, horizon, mapbox, paired t-test, parallel coordinates

* Create plugins for the rest one-off charts

* ignore chartplugin files from istanbul
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.28.0 labels Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.28.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants