[utils.py] gathering/refactoring into a "utils/" folder #6095
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mistercrunch
force-pushed
the
utils_folder
branch
5 times, most recently
from
dd72b3f
to
d2f3b4f
Compare
Codecov Report
@@ Coverage Diff @@
## master #6095 +/- ##
==========================================
- Coverage 77.23% 76.91% -0.33%
==========================================
Files 47 47
Lines 9349 9362 +13
==========================================
- Hits 7221 7201 -20
- Misses 2128 2161 +33
Continue to review full report at Codecov.
|
mistercrunch
force-pushed
the
utils_folder
branch
3 times, most recently
from
c955690
to
9f384b9
Compare
john-bodley
reviewed
Oct 16, 2018
tests/base_tests.py
Outdated
| @@ -23,22 +20,12 @@ class SupersetTestCase(unittest.TestCase): | |||
| examples_loaded = False | |||
There was a problem hiding this comment.
I think you can remove this.
Moving current utils.py into utils/core.py and moving other *util* modules under this new "utils/" as well. Following steps include eroding at "utils/core.py" and breaking it down into smaller modules.
mistercrunch
force-pushed
the
utils_folder
branch
from
4e0cfec
to
0bc0b13
Compare
bipinsoniguavus
pushed a commit
to ThalesGroup/incubator-superset
that referenced
this pull request
Dec 26, 2018
* [utils] gathering/refactoring into a "utils/" folder Moving current utils.py into utils/core.py and moving other *util* modules under this new "utils/" as well. Following steps include eroding at "utils/core.py" and breaking it down into smaller modules. * Improve tests * Make loading examples in scope for tests * Remove test class attrs examples_loaded and requires_examples
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moving current utils.py into utils/core.py and moving other util
modules under this new "utils/" as well.
Following steps include eroding at "utils/core.py" and breaking it down
into smaller modules.
Unit tests speed up
I did a bunch of unrelated changes that lead to shaving a lot of time off the Python unit test suite. It went for 15-ish minutes to 5-ish minutes. Somehow the examples were getting loaded over and over for each class that was getting triggered in parallel.
On the down side,load_examplesnow falls off of coverage accounting, meaning we loose 6% of coverage for the piece of code that loads the example. Somehow it's not easy to getnoseteststo force a certain order. Personally I think it's worth the tradeoff.