[superset-client] use getClientErrorObject for client error handling #6163
Conversation
williaster
changed the title
| }); | ||
| }); | ||
|
|
||
| it('Handles Repsonse that can be parsed as json', () => { |
| }); | ||
| }); | ||
|
|
||
| it('Handles Repsonse that can be parsed as text', () => { |
williaster
changed the title
|
🤮 build is stuck ... will give it a bit more time to sort itself out. |
|
Need to merge #6133 before this one |
|
@williaster I wanted to add this into If it's not easy maybe I just need to cut |
|
Hmm, it would probably need all of SupersetClient PRs because it may have been introduced in one of the earlier ones. they were #5875 chart ajax (introduced bug?) unsure, |
|
I think |
…pache#6163) * [superset-client] use getClientErrorObject for client error handling * fix getClientErrorObject json parsing * fix getClientErrorObject test typos * kick build (cherry picked from commit d8d50a1)
…pache#6163) * [superset-client] use getClientErrorObject for client error handling * fix getClientErrorObject json parsing * fix getClientErrorObject test typos * kick build
mistercrunch
added
🏷️ bot
This PR fixes #6152 and is a more generic fix than #6158 for handling fetch-based errors.
It adds a method
getClientErrorObjectwhich takes a fetchResponseas input, reads it as eitherjsonortext, and returns aPromisethat resolves to an object with all keys from theResponseand anerrorkey which can be used for display in the UI.Note this is more complex than previous
ajaxerrors because we must read the response explicitly, and because of the mixture of response types we have no idea if it's text or json.Added unit tests and tested locally for bug reported in #6152
@mistercrunch @graceguo-supercat @kristw @michellethomas