[explore] Include "Autocomplete Query Predicate" field to Table Editor #6171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mistercrunch
changed the title
Codecov Report
@@ Coverage Diff @@
## master #6171 +/- ##
==========================================
+ Coverage 76.91% 76.91% +<.01%
==========================================
Files 47 47
Lines 9362 9363 +1
==========================================
+ Hits 7201 7202 +1
Misses 2161 2161
Continue to review full report at Codecov.
|
xtinec
reviewed
Oct 24, 2018
| @@ -336,6 +336,18 @@ export class DatasourceEditor extends React.PureComponent { | |||
| descr={t('Whether to populate autocomplete filters options')} | |||
| control={<CheckboxControl />} | |||
| /> | |||
| {this.state.isSqla && | |||
There was a problem hiding this comment.
Perhaps a quick unit test for the conditional rendering? :)
mistercrunch
force-pushed
the
fetch_values_predicate
branch
from
f39be7c
to
e03b445
Compare
|
Addressed comments, merging |
mistercrunch
added a commit
to lyft/incubator-superset
that referenced
this pull request
Oct 29, 2018
apache#6171) * Improvements around filters * Adding simple test (cherry picked from commit 5403f31)
youngyjd
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Nov 2, 2018
apache#6171) * Improvements around filters * Adding simple test (cherry picked from commit 5403f31) (cherry picked from commit 2e3e063)
youngyjd
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Nov 2, 2018
apache#6171) * Improvements around filters * Adding simple test (cherry picked from commit 5403f31) (cherry picked from commit 2e3e063)
bipinsoniguavus
pushed a commit
to ThalesGroup/incubator-superset
that referenced
this pull request
Dec 26, 2018
apache#6171) * Improvements around filters * Adding simple test
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@betodealmeida