Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bugfix] Fix issue with line_multi #6183

Merged
merged 1 commit into from Oct 25, 2018

Conversation

kristw
Copy link
Contributor

@kristw kristw commented Oct 25, 2018

line_multi layout is broken because it receives NaN as width.
This PR fixes the issue.

@williaster @graceguo-supercat @michellethomas @conglei

Copy link
Contributor

@michellethomas michellethomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@williaster williaster merged commit ef8429c into apache:master Oct 25, 2018
michellethomas pushed a commit to michellethomas/panoramix that referenced this pull request Oct 25, 2018
(cherry picked from commit ef8429c)
@kristw kristw deleted the kristw-fix-line-multi branch October 26, 2018 01:28
bipinsoniguavus pushed a commit to ThalesGroup/incubator-superset that referenced this pull request Dec 26, 2018
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.34.0 labels Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.34.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants