[fix] should set chartUpdateEndTime when chart fetch failed or stopped #6205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kristw
approved these changes
Oct 26, 2018
williaster
approved these changes
Oct 26, 2018
Codecov Report
@@ Coverage Diff @@
## master #6205 +/- ##
=======================================
Coverage 76.91% 76.91%
=======================================
Files 47 47
Lines 9393 9393
=======================================
Hits 7225 7225
Misses 2168 2168Continue to review full report at Codecov.
|
|
|
graceguo-supercat
pushed a commit
to graceguo-supercat/superset
that referenced
this pull request
Oct 30, 2018
apache#6205) (cherry picked from commit dcf048c)
bipinsoniguavus
pushed a commit
to ThalesGroup/incubator-superset
that referenced
this pull request
Dec 26, 2018
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we should update chart state chartUpdateEndTime when chart fetching is timeout or stopped.
@michellethomas @kristw @williaster