Fix time range filter dropdown

[michellethomas]

When on a chart with custom time range, the time range dropdown doesn't open in the custom tab, it always opens in the default tab. I fixed the issue by moving the logic in componentDidMount for setting state to componentWillMount.

While looking into that issue, I noticed another. If you start out on the custom tab and go to the default tab where a radio button has already been set, when you hit OK without clicking another button the filter doesn't get updated correctly. The radio buttons only update the type field in state if you click a button, so if the value is already selected, it won't change the type. I fixed it by keeping track of the current tab so in close() we can use the common filter if the type has not been set but the tab is default.

Here's a video of the second issue (the "Last day" filter doesn't get set correctly):

Fixes #6114

@betodealmeida

[michellethomas]

@graceguo-supercat @kristw PR fixes a few issues with the time filter dropdown

[codecov-io]

Codecov Report

Merging #6223 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #6223   +/-   ##
=======================================
  Coverage   76.85%   76.85%           
=======================================
  Files          47       47           
  Lines        9393     9393           
=======================================
  Hits         7219     7219           
  Misses       2174     2174

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e1a3a68...3fb0f65. Read the comment docs.