[Fix] merge since, until request parameter with time_range #6251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #6251 +/- ##
==========================================
+ Coverage 76.85% 77.28% +0.43%
==========================================
Files 47 47
Lines 9393 10645 +1252
==========================================
+ Hits 7219 8227 +1008
- Misses 2174 2418 +244
Continue to review full report at Codecov.
|
| @@ -1032,11 +1032,16 @@ def get_form_data(self, slice_id=None, use_slice_data=False): | |||
| slc = db.session.query(models.Slice).filter_by(id=slice_id).first() | |||
| slice_form_data = slc.form_data.copy() | |||
| # allow form_data in request override slice from_data | |||
| if 'time_range' in form_data: | |||
There was a problem hiding this comment.
Add a comment like: we need to do this here so form_data has precedence over slice for time fields.
|
@betodealmeida touched this last, might want an approval from him on this |
graceguo-supercat
force-pushed
the
gg-FixTimeRangeParameterOverride
branch
from
bbf71d9
to
edd6781
Compare
|
LGTM, thanks for fixing this @graceguo-supercat! |
graceguo-supercat
pushed a commit
to graceguo-supercat/superset
that referenced
this pull request
Nov 1, 2018
(cherry picked from commit 7d8e321)
bipinsoniguavus
pushed a commit
to ThalesGroup/incubator-superset
that referenced
this pull request
Dec 26, 2018
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When exploring, Superset allow request parameter override slice parameter.
There is an issue that slice has time_range parameter, while request has since/until (or vise verse), they didn't merge correct. Example: annotation request like:
http://localhost:8080/superset/slice_json/240?form_data=%7B%22until%22%3A%222008-10-30T00%3A00%3A00%22%7D
@betodealmeida @fabianmenges @michellethomas @kristw