Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix warning] Warning: Failed prop type: Invalid prop bsSize of value md #6293

Merged
merged 1 commit into from Nov 8, 2018

Conversation

mistercrunch
Copy link
Member

No description provided.

@codecov-io
Copy link

codecov-io commented Nov 7, 2018

Codecov Report

Merging #6293 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #6293   +/-   ##
=======================================
  Coverage   77.01%   77.01%           
=======================================
  Files          64       64           
  Lines        9508     9508           
=======================================
  Hits         7323     7323           
  Misses       2185     2185

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 69e8df4...1ae303f. Read the comment docs.

@kristw
Copy link
Contributor

kristw commented Nov 8, 2018

Does it fallback to sm or lg? Perhaps explicitly say it's lg`.

@mistercrunch
Copy link
Member Author

It's just medium if you don't specify it. This just removed the warning.

@kristw
Copy link
Contributor

kristw commented Nov 8, 2018

👍

@mistercrunch mistercrunch merged commit 2607d0a into apache:master Nov 8, 2018
@mistercrunch mistercrunch deleted the fix_size_md branch November 8, 2018 07:12
bipinsoniguavus pushed a commit to ThalesGroup/incubator-superset that referenced this pull request Dec 26, 2018
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.34.0 labels Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.34.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants