Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cypress] Test dashboard save/save_as functions #6361

Merged

Conversation

graceguo-supercat
Copy link

@graceguo-supercat graceguo-supercat commented Nov 10, 2018

after #6350, #6189, add integration tests for dashboard save, save_as functions.

@williaster @michellethomas @kristw

@codecov-io
Copy link

codecov-io commented Nov 10, 2018

Codecov Report

Merging #6361 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #6361   +/-   ##
=======================================
  Coverage   77.33%   77.33%           
=======================================
  Files          67       67           
  Lines        9578     9578           
=======================================
  Hits         7407     7407           
  Misses       2171     2171

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ffb48c...29fd312. Read the comment docs.

@mistercrunch
Copy link
Member

LGTM

@graceguo-supercat graceguo-supercat merged commit 1a5ca35 into apache:master Nov 12, 2018
@graceguo-supercat graceguo-supercat deleted the gg-TestDashboardSave branch November 13, 2018 07:36
bipinsoniguavus pushed a commit to ThalesGroup/incubator-superset that referenced this pull request Dec 26, 2018
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.34.0 labels Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.34.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants