Minor improvements to Histogram viz #6391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* prevent legend overflow (spill) by simply hiding it * legend title only includes metric name when necessary * control validator asking forcing at least one numeric column to be selected
Codecov Report
@@ Coverage Diff @@
## master #6391 +/- ##
==========================================
- Coverage 77.31% 77.29% -0.03%
==========================================
Files 67 67
Lines 9581 9585 +4
==========================================
+ Hits 7408 7409 +1
- Misses 2173 2176 +3
Continue to review full report at Codecov.
|
|
👍 |
hughhhh
approved these changes
Nov 18, 2018
bipinsoniguavus
pushed a commit
to ThalesGroup/incubator-superset
that referenced
this pull request
Dec 26, 2018
* Minor improvements to Histogram viz * prevent legend overflow (spill) by simply hiding it * legend title only includes metric name when necessary * control validator asking forcing at least one numeric column to be selected * Removing print()
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
selected
In production at Lyft since 11/11/18
@hughhhh