replace missing round function in d3 to fix MapBox #6444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aboganas
changed the title
mistercrunch
requested changes
Nov 27, 2018
|
You can run |
Codecov Report
@@ Coverage Diff @@
## master #6444 +/- ##
==========================================
- Coverage 73.37% 73.36% -0.01%
==========================================
Files 67 67
Lines 9587 9584 -3
==========================================
- Hits 7034 7031 -3
Misses 2553 2553
Continue to review full report at Codecov.
|
thanks for guiding me with my first PR of more to come |
aboganas
commented
Nov 27, 2018
mistercrunch
approved these changes
Nov 28, 2018
|
|
mistercrunch
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Dec 10, 2018
* replace missing round function in d3 * added unit test * fixed linting (cherry picked from commit 71a713d)
bipinsoniguavus
pushed a commit
to ThalesGroup/incubator-superset
that referenced
this pull request
Dec 26, 2018
* replace missing round function in d3 * added unit test * fixed linting
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR to fix issue #6279 as round function in d3 seems to be deprecated.