Fixing error when clearing big number metric #6465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kristw
added
!deprecated-label:bug
kristw
approved these changes
Nov 30, 2018
bipinsoniguavus
pushed a commit
to ThalesGroup/incubator-superset
that referenced
this pull request
Dec 26, 2018
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the error we were seeing when clearing the metric on big number.
transformPropsgets run every time the chart or chart controls changes, so when you clear a metric, instead of showing the overlay, we'll show NaN until the user selects a new metric. I'll create a separate issue so that moving forward we can handle this case better (and possibly move this logic out of transformProps).Fixes #6447
Tested big number with:
Saved metric
Adhoc metric
Cleared metric and added new
@kristw @graceguo-supercat