Fix for #6590: Numeric values in columns sometimes returned as quoted strings #6591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soboko
changed the title
kristw
changed the title
kristw
changed the title
soboko
force-pushed
the
council--incubator-superset-issue-6590
branch
from
376b4bc
to
cfe048c
Compare
soboko
changed the title
kristw
approved these changes
Jan 14, 2019
williaster
reviewed
Jan 14, 2019
| @@ -1,5 +1,4 @@ | |||
| import shortid from 'shortid'; | |||
| import JSONbig from 'json-bigint'; | |||
There was a problem hiding this comment.
you can also now remove this dependency? EDIT: maybe not since you still use it below.
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for: #6590
Fairly detailed explanation of the issue can be found at that link.
to: @conglei @williaster @kristw
cc: @john-bodley