Remove dep on unidecode #6673
Merged
Remove dep on unidecode #6673
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not needed anymore in py3
Codecov Report
@@ Coverage Diff @@
## master #6673 +/- ##
==========================================
- Coverage 56.24% 56.24% -0.01%
==========================================
Files 519 519
Lines 23088 23087 -1
Branches 2756 2756
==========================================
- Hits 12986 12985 -1
Misses 9693 9693
Partials 409 409
Continue to review full report at Codecov.
|
|
Lgtm |
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not needed anymore in py3