Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose more columns in saved queries API #6686

Merged
merged 2 commits into from Jan 18, 2019
Merged

Conversation

betodealmeida
Copy link
Member

I've updated SavedQueryAPI to show more columns, including the user's email and the database SQLAlchemy URI. This is in preparation to introducing scheduled queries.

@mistercrunch I could use your input here, is there best practices for changing the views?

@kristw kristw added the need:rebase Requires rebasing on top of current master label Jan 15, 2019
@codecov-io
Copy link

codecov-io commented Jan 16, 2019

Codecov Report

Merging #6686 into master will increase coverage by <.01%.
The diff coverage is 60%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6686      +/-   ##
==========================================
+ Coverage   56.19%   56.19%   +<.01%     
==========================================
  Files         520      520              
  Lines       23181    23186       +5     
  Branches     2765     2765              
==========================================
+ Hits        13027    13030       +3     
- Misses       9744     9746       +2     
  Partials      410      410
Impacted Files Coverage Δ
superset/views/sql_lab.py 93.75% <100%> (+0.13%) ⬆️
superset/models/sql_lab.py 95.65% <50%> (-2.81%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1dd4d7a...6b50876. Read the comment docs.

@mistercrunch
Copy link
Member

LGTM

@betodealmeida betodealmeida merged commit b260cb6 into apache:master Jan 18, 2019
@betodealmeida betodealmeida added change:backend Requires changing the backend v0.31 and removed need:rebase Requires rebasing on top of current master labels Jan 22, 2019
@kristw kristw added enhancement:request Enhancement request submitted by anyone from the community and removed #refine labels Mar 20, 2019
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.34.0 labels Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels change:backend Requires changing the backend enhancement:request Enhancement request submitted by anyone from the community v0.31 🚢 0.34.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants