Bump PyHive version for prod requirements.txt #6751
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not sure why this would have failed. |
|
@kristw is there a way to kick off tests in the comments? e.g. "run tests" |
|
Unfortunately, there is not. I just manually trigger the one failed test to see if the failure is due to randomness. If this persist, you may want to investigate a bit more. |
|
phew. it passed that time. Thanks for re-running. @kristw looks like it was randomness or some sort of race condition. I always test locally before I open a pull request, so I can limit whether I waste the maintainers' time or not. |
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So, I encountered a few bugs when running Superset in a production environment and attempting to leverage the Hive connector. An example bug was that connection statuses were showing
RUNNINGwhenFINISHEDwas expected. That problem went away after I changed the version.It went unnoticed for me, and evidently others as well, in a dev environment because the
dev-requirements.txtpoints to>=0.6.1, whilerequirements.txtcurrently points to>=0.4.0.