Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Fix dashboard links in welcome page #6756

Merged
merged 1 commit into from Jan 25, 2019
Merged

Conversation

hughhhh
Copy link
Member

@hughhhh hughhhh commented Jan 25, 2019

Fixing issue with dashboard links on the welcome page not being clickable.

@kristw kristw added the !deprecated-label:bug Deprecated label - Use #bug instead label Jan 25, 2019
@codecov-io
Copy link

Codecov Report

Merging #6756 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #6756   +/-   ##
=======================================
  Coverage   56.06%   56.06%           
=======================================
  Files         525      525           
  Lines       23218    23218           
  Branches     2777     2777           
=======================================
  Hits        13018    13018           
  Misses       9791     9791           
  Partials      409      409
Impacted Files Coverage Δ
superset/assets/src/welcome/DashboardTable.jsx 87.5% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 01689c3...09c2adc. Read the comment docs.

@mistercrunch
Copy link
Member

LGTM

@mistercrunch mistercrunch merged commit 6b0ab21 into master Jan 25, 2019
@mistercrunch mistercrunch deleted the fix-dashboard-links branch January 25, 2019 16:20
hughhhh added a commit to lyft/incubator-superset that referenced this pull request Feb 26, 2019
@xtinec xtinec added the v0.31 label Mar 12, 2019
graceguo-supercat pushed a commit that referenced this pull request Mar 12, 2019
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.34.0 labels Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels !deprecated-label:bug Deprecated label - Use #bug instead v0.31 🚢 0.34.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants