Fix play slider in deck.gl visualizations #6797
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
betodealmeida
added
!deprecated-label:bug
Codecov Report
@@ Coverage Diff @@
## master #6797 +/- ##
==========================================
- Coverage 56.07% 56.07% -0.01%
==========================================
Files 526 526
Lines 23251 23253 +2
Branches 2782 2783 +1
==========================================
Hits 13038 13038
- Misses 9804 9806 +2
Partials 409 409
Continue to review full report at Codecov.
|
xtinec
approved these changes
Feb 1, 2019
|
LGTM |
|
@xtinec careful when you merge to always use "Squash and Merge", it makes release management easier |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The play slider was broken because before we would call
constructorfor every query, and we no longer do that.Tested with the scatterplot deck.gl demo, and it now works as expected.