Allow for dynamic feature flags #6808
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Giving more control over feature flags, allowing administrator to define custom logic around whether features are enabled for particular users / roles. The exposed function can be used for things like: * progressive rollout of features (1%, 5%, 50%, 100%) * experimentation * role-based feature affectation (only admins see a particular feature)
mistercrunch
force-pushed
the
dynamic_feature_flags
branch
from
541e1f9
to
f7ed792
Compare
Codecov Report
@@ Coverage Diff @@
## master #6808 +/- ##
==========================================
+ Coverage 56.03% 56.32% +0.28%
==========================================
Files 527 527
Lines 23286 23536 +250
Branches 2788 2782 -6
==========================================
+ Hits 13049 13257 +208
- Misses 9827 9867 +40
- Partials 410 412 +2
Continue to review full report at Codecov.
|
hughhhh
reviewed
Feb 7, 2019
hughhhh
reviewed
Feb 7, 2019
kristw
added
the
enhancement:request
|
Addressed all comments |
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Giving more control over feature flags, allowing administrator to define
custom logic around whether features are enabled for particular users /
roles.
The exposed function can be used for things like: