Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding template_params to datasource editor for sqla tables #6869

Conversation

michellethomas
Copy link
Contributor

If a sqla table previously had template_params, saving changes in the datasource editor will override template_params. To fix this, I'm adding the template_params field to the "Advanced" section of the table editor.

Tested by:
Created a sqllab datasource based on birth names with jinja params.
Edited the template_params using the datasource editor and confirmed that the param was getting updated.

@mistercrunch @graceguo-supercat @john-bodley

@kristw kristw added the enhancement:request Enhancement request submitted by anyone from the community label Feb 13, 2019
@codecov-io
Copy link

Codecov Report

Merging #6869 into master will increase coverage by 0.09%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6869      +/-   ##
==========================================
+ Coverage   56.22%   56.32%   +0.09%     
==========================================
  Files         527      527              
  Lines       23529    23532       +3     
  Branches     2782     2784       +2     
==========================================
+ Hits        13229    13254      +25     
+ Misses       9888     9866      -22     
  Partials      412      412
Impacted Files Coverage Δ
...uperset/assets/src/datasource/DatasourceEditor.jsx 61.84% <100%> (+0.5%) ⬆️
superset/connectors/sqla/models.py 81.53% <100%> (+0.03%) ⬆️
superset/views/core.py 75.01% <0%> (+0.28%) ⬆️
superset/models/core.py 83.56% <0%> (+0.62%) ⬆️
superset/db_engine_specs.py 53.82% <0%> (+1.84%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f47c61...1a1fae4. Read the comment docs.

@michellethomas michellethomas merged commit b0f7f51 into apache:master Feb 15, 2019
@michellethomas michellethomas deleted the fix_datasource_editor_template_params branch February 15, 2019 19:16
john-bodley pushed a commit that referenced this pull request Feb 15, 2019
graceguo-supercat pushed a commit to graceguo-supercat/superset that referenced this pull request Mar 18, 2019
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.34.0 labels Feb 28, 2024
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels enhancement:request Enhancement request submitted by anyone from the community 🚢 0.34.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants