Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(critical-vulnerability) Fixed Unexpected unknown type selector "=" reported by SonarQube #7034

Merged
merged 1 commit into from Mar 15, 2019

Conversation

bipinsoniguavus
Copy link
Contributor

@bipinsoniguavus bipinsoniguavus commented Mar 14, 2019

#bug Unexpected unknown type selector "=" reported by SonarQube as a critical vulnerability

  • [✔️] I have checked the superset logs for python stacktraces and included it here as text if there are any.
  • [✔️] I have reproduced the issue with at least the latest released version of superset.
  • [✔️] I have checked the issue tracker for the same issue and I haven't found one similar.

Superset version

0.29

Expected results

SonarQube should not report critical vulnerability

Actual results

SonarQube report shows critical vulnerability

Steps to reproduce

Run SonarQube server to check the report generated by it, it will show the critical vulnerability as
Unexpected unknown type selector "=". For reference, please check the screenshot

Screenshot 2019-03-14 at 10 49 48 PM

…d by sonarqube report as a critical vulnerability
Copy link
Contributor

@ankursinghal2005 ankursinghal2005 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bipinsoniguavus bipinsoniguavus changed the title fix(css-selector) Fixed Unexpected unknown type selector "=" reported by SonarQube fix(critical-vulnerability) Fixed Unexpected unknown type selector "=" reported by SonarQube Mar 14, 2019
@codecov-io
Copy link

codecov-io commented Mar 14, 2019

Codecov Report

Merging #7034 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #7034   +/-   ##
=======================================
  Coverage   64.45%   64.45%           
=======================================
  Files         421      421           
  Lines       20523    20523           
  Branches     2245     2245           
=======================================
  Hits        13229    13229           
  Misses       7167     7167           
  Partials      127      127

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 05be866...0a5fe33. Read the comment docs.

@kristw kristw added the !deprecated-label:bug Deprecated label - Use #bug instead label Mar 14, 2019
@mistercrunch mistercrunch merged commit 4ca2cc1 into apache:master Mar 15, 2019
@bipinsoniguavus bipinsoniguavus deleted the fix/sonarqube-vulnerability branch March 22, 2019 16:06
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.34.0 labels Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels !deprecated-label:bug Deprecated label - Use #bug instead 🚢 0.34.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants