[api/v1][query_obj] add default prequeries array #7039
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR only affects the embeddable charts
/api/v1/query
endpoint. I'm working on addingreact
<ChartDataProvider />
components in@superset-ui
and when I use the new (non-legacy)WordCloudPlugin
together withSuperChart
+ChartClient
I get the following stack trace from Python in the Superset App:POST /api/v1/query/
=>{"datasource":{"id":3,"type":"table"},"queries":[{"granularity":"ds","metrics":[{"label":"sum__num"}],"groupby":["name"]}]}
This is because
prequeries
is not passed for this chart, and there is no default on the Python side. This PR adds a default and updates the type, I think it's an optionalList
ofDict
s, setting the default to{}
errored downstream as something was trying to append to it 😄 so maybe it was typed wrong?@xtinec @conglei @kristw