add kerberos for druid #7091
add kerberos for druid #7091
Conversation
Codecov Report
@@ Coverage Diff @@
## master #7091 +/- ##
==========================================
- Coverage 64.61% 64.58% -0.04%
==========================================
Files 422 422
Lines 20607 20624 +17
Branches 2253 2253
==========================================
+ Hits 13315 13319 +4
- Misses 7170 7183 +13
Partials 122 122
Continue to review full report at Codecov.
|
kristw
added
enhancement:request
|
what can`t be done ? |
|
？ |
| return False | ||
|
|
||
| kerberos_commands = 'kinit -k -t %s %s' % (kerberos_keytab, kerberos_principal) | ||
| subprocess.call(kerberos_commands, shell=True) |
There was a problem hiding this comment.
Not sure I feel comfortable shelling out like this, from within a model, no less. This sort of logic belongs in a higher layer (connection manager, perhaps?)
|
|
||
| def get_druid_version(self): | ||
|
|
| @@ -72,3 +72,4 @@ webencodings==0.5.1 # via bleach | |||
| werkzeug==0.14.1 # via flask | |||
| wtforms-json==0.3.3 | |||
| wtforms==2.2.1 # via flask-wtf, wtforms-json | |||
| requests-kerberos==0.12.0 | |||
There was a problem hiding this comment.
+1 let's create a kerberos group in extra_requires
|
Any news on this pull request? |
|
Looks like there's merge conflicts, and there were a few comments that weren't addressed. |
|
FYI, the Druid connector is getting deprecated [slowly over time] in favor of using SQLAlchemy and the SQL interface to Druid. We can still merge this once the comments are addressed, but the core committers will fade out of supporting the native Druid connector. This aligns with the Druid roadmap where they're clearly doubling down on the SQL interface |
add kerberos configure for Druid