Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#5791: Address errors found by lgtm.com #7403

Closed
wants to merge 16 commits into from
Closed

#5791: Address errors found by lgtm.com #7403

wants to merge 16 commits into from

Commits on Jun 26, 2019

  1. apache#5791: Return 404 when requesting access to unexisting dashboar… 

    …d ID
    @sturmer
    sturmer committed Jun 26, 2019
    Copy the full SHA
    d1b1094 View commit details
    Browse the repository at this point in the history

  2. 5791: Remove unused variables/imports

    @sturmer
    sturmer committed Jun 26, 2019
    Copy the full SHA
    c9fab71 View commit details
    Browse the repository at this point in the history

  3. 5791: Call parent class' __init__ in child's __init__ method

    @sturmer
    sturmer committed Jun 26, 2019
    Copy the full SHA
    979840b View commit details
    Browse the repository at this point in the history

  4. 5791: Fix lint issues

    @sturmer
    sturmer committed Jun 26, 2019
    Copy the full SHA
    6ea76bd View commit details
    Browse the repository at this point in the history

  5. 5791: Fix mutation of descriptor in __get__

    @sturmer
    sturmer committed Jun 26, 2019
    Copy the full SHA
    1f52a29 View commit details
    Browse the repository at this point in the history

  6. Start addressing the reviewers' comments

    @sturmer
    sturmer committed Jun 26, 2019
    Copy the full SHA
    c7f78cd View commit details
    Browse the repository at this point in the history

  7. Set is_method in copy instance

    @sturmer
    sturmer committed Jun 26, 2019
    Copy the full SHA
    6d596d1 View commit details
    Browse the repository at this point in the history

  8. Split long line

    @sturmer
    sturmer committed Jun 26, 2019
    Copy the full SHA
    190520b View commit details
    Browse the repository at this point in the history

  9. Fix call to super

    @sturmer
    sturmer committed Jun 26, 2019
    Copy the full SHA
    6167d3e View commit details
    Browse the repository at this point in the history

  10. Try correct indent

    @sturmer
    sturmer committed Jun 26, 2019
    Copy the full SHA
    44a8d1d View commit details
    Browse the repository at this point in the history

  11. Silence the alert

    @sturmer
    sturmer committed Jun 26, 2019
    Copy the full SHA
    b22fd24 View commit details
    Browse the repository at this point in the history

  12. Address warning-level issues

    @sturmer
    sturmer committed Jun 26, 2019
    Copy the full SHA
    23ca06c View commit details
    Browse the repository at this point in the history

  13. Address more warnings

    @sturmer
    sturmer committed Jun 26, 2019
    Copy the full SHA
    bc6fba0 View commit details
    Browse the repository at this point in the history

  14. Remove linter errors

    @sturmer
    sturmer committed Jun 26, 2019
    Copy the full SHA
    06a68c8 View commit details
    Browse the repository at this point in the history

  15. Remove file introduced by mistake, call static method correctly

    @sturmer
    sturmer committed Jun 26, 2019
    Copy the full SHA
    a14dee9 View commit details
    Browse the repository at this point in the history

  16. Remove todo

    @sturmer
    sturmer committed Jun 26, 2019
    Copy the full SHA
    2b0d317 View commit details
    Browse the repository at this point in the history