Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WiP] work on Superset example improvement #7472

Closed
wants to merge 114 commits into from

Conversation

rjurney
Copy link
Contributor

@rjurney rjurney commented May 8, 2019

CATEGORY

Choose one

  • Bug Fix
  • Enhancement (new features, refinement)
  • Refactor
  • Add tests
  • Build / Development Environment
  • Documentation

SUMMARY

This pull request represents in progress work on improving the examples capabilities of superset.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TEST PLAN

I will add tox testing to the cli, which at the moment has none.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

REVIEWERS

@mistercrunch

@rjurney
Copy link
Contributor Author

rjurney commented May 21, 2019

See SIP for this work in #7571

@rjurney
Copy link
Contributor Author

rjurney commented Jun 22, 2019

@mistercrunch Ok, latest commit removes uuid field from the scheduler classes in the migration. I think this is about where it needs to be, minus a couple of things noted in the SIP. Have at!

mistercrunch added a commit to preset-io/superset that referenced this pull request Jul 13, 2019
related to apache#7472, longer term we will generate the examples by exporting
them into tarball as in apache#7472. In the meantime, we need this subset of
the features:

* allowing specifying an alternate database connection for examples
* allowing a --only-metadata flag to `load_examples` to load only
  dashboard and chart definitions, no actual data is loaded
mistercrunch added a commit to mistercrunch/superset that referenced this pull request Jul 16, 2019
related to apache#7472, longer term we will generate the examples by exporting
them into tarball as in apache#7472. In the meantime, we need this subset of
the features:

* allowing specifying an alternate database connection for examples
* allowing a --only-metadata flag to `load_examples` to load only
  dashboard and chart definitions, no actual data is loaded
mistercrunch added a commit that referenced this pull request Jul 17, 2019
* [WiP] improve load_examples

related to #7472, longer term we will generate the examples by exporting
them into tarball as in #7472. In the meantime, we need this subset of
the features:

* allowing specifying an alternate database connection for examples
* allowing a --only-metadata flag to `load_examples` to load only
  dashboard and chart definitions, no actual data is loaded

* Improve logging

* Rename data->examples

* Load only if not exist

* By default do not load, add a force flag

* fix build

* set published to true
alex-mark pushed a commit to alex-mark/incubator-superset that referenced this pull request Jul 29, 2019
* [WiP] improve load_examples

related to apache#7472, longer term we will generate the examples by exporting
them into tarball as in apache#7472. In the meantime, we need this subset of
the features:

* allowing specifying an alternate database connection for examples
* allowing a --only-metadata flag to `load_examples` to load only
  dashboard and chart definitions, no actual data is loaded

* Improve logging

* Rename data->examples

* Load only if not exist

* By default do not load, add a force flag

* fix build

* set published to true
@stale
Copy link

stale bot commented Aug 21, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. For admin, please label this issue .pinned to prevent stale bot from closing the issue.

@stale stale bot added the inactive Inactive for >= 30 days label Aug 21, 2019
@stale stale bot closed this Aug 28, 2019
@mistercrunch mistercrunch mentioned this pull request Sep 9, 2019
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
inactive Inactive for >= 30 days size/XXL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants