Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug where lists in queries cannot contain multiple types #8032

Merged
merged 2 commits into from Aug 13, 2019
Merged

Fix bug where lists in queries cannot contain multiple types #8032

merged 2 commits into from Aug 13, 2019

Conversation

serenajiang
Copy link
Contributor

CATEGORY

Choose one

  • Bug Fix
  • Enhancement (new features, refinement)
  • Refactor
  • Add tests
  • Build / Development Environment
  • Documentation

SUMMARY

Use set instead of sorted to check equality of lists to allow for lists in queries to contain different types.

TEST PLAN

Edited test_merge_extra_filters_ignores_equal_filters to include a test case for a list containing different types. Passes all tests.

REVIEWERS

@etr2460 @john-bodley @michellethomas

@serenajiang serenajiang reopened this Aug 13, 2019
villebro
villebro approved these changes Aug 13, 2019
View reviewed changes
Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch 👍

@villebro villebro merged commit 17f0740 into apache:master Aug 13, 2019
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.35.0 labels Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mistercrunch mistercrunch mistercrunch approved these changes

@villebro villebro villebro approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S 🚢 0.35.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@serenajiang @mistercrunch @villebro