Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump flask-appbuilder to 2.1.13 #8174

Merged
merged 2 commits into from Sep 8, 2019
Merged

Conversation

paulvic
Copy link
Contributor

@paulvic paulvic commented Sep 4, 2019

CATEGORY

Choose one

  • Bug Fix
  • Enhancement (new features, refinement)
  • Refactor
  • Add tests
  • Build / Development Environment
  • Documentation

SUMMARY

Bumping FAB version to pick up dpgaspar/Flask-AppBuilder#1095 which addresses #7739

Currently OAuth logins result in the following error after authentication:

File "/src/superset/superset/venv/lib/python3.6/site-packages/flask_appbuilder/security/views.py", line 677, in oauth_authorized
resp = self.appbuilder.sm.oauth_remotes[provider].authorized_response()
KeyError: 'login'

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TEST PLAN

  1. Enable Google SSO following instructions here: http://superset.apache.org/installation.html#custom-oauth2-configuration
  2. Login and validate you are successfully redirected to /superset/welcome

ADDITIONAL INFORMATION

  • Has associated issue: Fixes Custom OAuth issue #7739
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

REVIEWERS

@mistercrunch @dpgaspar

@dpgaspar
Copy link
Member

dpgaspar commented Sep 4, 2019

Can you bump it to 2.1.13?

@paulvic paulvic changed the title Bump flask-appbuilder to 2.1.12 Bump flask-appbuilder to 2.1.13 Sep 5, 2019
@codecov-io
Copy link

Codecov Report

Merging #8174 into master will decrease coverage by 7.55%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #8174      +/-   ##
=========================================
- Coverage   73.75%   66.2%   -7.56%     
=========================================
  Files         115     479     +364     
  Lines       12053   22930   +10877     
  Branches        0    2524    +2524     
=========================================
+ Hits         8890   15180    +6290     
- Misses       3163    7616    +4453     
- Partials        0     134     +134
Impacted Files Coverage Δ
superset/assets/src/components/Checkbox.jsx 100% <0%> (ø)
...ations/deckgl/layers/Polygon/PolygonChartPlugin.js 0% <0%> (ø)
.../assets/src/dashboard/reducers/dashboardFilters.js 88.23% <0%> (ø)
...ets/src/dashboard/components/dnd/DragDroppable.jsx 94.59% <0%> (ø)
...c/visualizations/deckgl/layers/Polygon/Polygon.jsx 0% <0%> (ø)
superset/assets/src/components/EditableTitle.jsx 81.81% <0%> (ø)
superset/assets/src/setup/setupPlugins.js 0% <0%> (ø)
...t/assets/src/components/InfoTooltipWithTrigger.jsx 41.66% <0%> (ø)
.../src/dashboard/components/UndoRedoKeylisteners.jsx 9.52% <0%> (ø)
...ts/src/explore/components/ExploreActionButtons.jsx 100% <0%> (ø)
... and 354 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ae0dc30...cf85f4d. Read the comment docs.

@mistercrunch mistercrunch merged commit 22302e3 into apache:master Sep 8, 2019
@paulvic paulvic deleted the patch-1 branch September 9, 2019 15:16
@villebro villebro added the v0.34 label Sep 27, 2019
villebro pushed a commit that referenced this pull request Sep 27, 2019
* Bump flask-appbuilder to 2.1.12

To pick up this fix dpgaspar/Flask-AppBuilder#1095 which addresses #7739

* Bump FAB again to 2.1.13
@smacker smacker mentioned this pull request Oct 18, 2019
2 tasks
@mistercrunch mistercrunch added 🍒 0.34.1 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.35.0 labels Feb 28, 2024
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
* Bump flask-appbuilder to 2.1.12

To pick up this fix dpgaspar/Flask-AppBuilder#1095 which addresses apache#7739

* Bump FAB again to 2.1.13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS v0.34 🍒 0.34.1 🚢 0.35.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Custom OAuth issue
5 participants