Simplify and improve expand_data in Presto
#8233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #8233 +/- ##
==========================================
+ Coverage 65.98% 66.03% +0.04%
==========================================
Files 479 479
Lines 23038 23105 +67
Branches 2552 2552
==========================================
+ Hits 15202 15257 +55
- Misses 7700 7712 +12
Partials 136 136
Continue to review full report at Codecov.
|
khtruong
approved these changes
Sep 17, 2019
|
|
||
| For rows, we return a list of the columns: | ||
|
|
||
| >>> get_children(dict(name="a", type="ROW(BIGINT,FOO VARCHAR)")) |
There was a problem hiding this comment.
This is more for my understanding than a PR comment. I thought each row has a variable name before the type. For example ROW(FOO BIGINT, BAR VARCHAR). When will there be a nameless column again?
There was a problem hiding this comment.
Good question! If you do a query like:
SELECT ARRAY[ROW(100,0,'hello')]The resulting column has type ARRAY(ROW(INTEGER,INTEGER,VARCHAR(5))), without names.
This was referenced Oct 4, 2019
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CATEGORY
Choose one
SUMMARY
This PR simplifies the logic of the
expand_datamethod in Presto, while making it more generic. Queries that were failing before, likeare now working.
Some of the methods in
db_engine_specs/presto.pyare no longer used and can be removed; I'll do that in a subsequent PR. I wanted to keep this PR simple and small because it's blocking an important release.TEST PLAN
I updated the unit tests, and tested with real data. I'll add more unit tests in the next PR, covering more complex cases.
ADDITIONAL INFORMATION
REVIEWERS
@khtruong