Avoid circular dependency between superset config and superset package #8254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkyryliuk
force-pushed
the
bogdan/support_custom_security_manager
branch
from
4c727fc
to
aa14dd3
Compare
|
I would rename A nice to have could be to import |
bkyryliuk
force-pushed
the
bogdan/support_custom_security_manager
branch
2 times, most recently
from
d05bb9d
to
9dfb3dd
Compare
Codecov Report
@@ Coverage Diff @@
## master #8254 +/- ##
==========================================
- Coverage 65.91% 65.78% -0.13%
==========================================
Files 482 483 +1
Lines 24157 24311 +154
Branches 2770 2771 +1
==========================================
+ Hits 15922 15992 +70
- Misses 8057 8141 +84
Partials 178 178
Continue to review full report at Codecov.
|
bkyryliuk
changed the title
|
@dpgaspar did you mean import |
|
Yep, just edited my previous reply |
|
@dpgaspar done |
dpgaspar
reviewed
Sep 27, 2019
superset/config.py
Outdated
| @@ -61,6 +61,9 @@ def _try_json_readfile(filepath): | |||
| return None | |||
|
|
|||
|
|
|||
| STATS_LOGGER = StatsdStatsLogger | |||
bkyryliuk
force-pushed
the
bogdan/support_custom_security_manager
branch
from
a35c118
to
c591ee0
Compare
bkyryliuk
force-pushed
the
bogdan/support_custom_security_manager
branch
from
c591ee0
to
7bec333
Compare
bkyryliuk
force-pushed
the
bogdan/support_custom_security_manager
branch
from
7bec333
to
8196da9
Compare
bkyryliuk
force-pushed
the
bogdan/support_custom_security_manager
branch
3 times, most recently
from
bdf4e0f
to
f731eae
Compare
Resolve comments Avoid circular dependency between superset config and superset package Resolve comments
bkyryliuk
force-pushed
the
bogdan/support_custom_security_manager
branch
from
f731eae
to
16bfea7
Compare
mistercrunch
approved these changes
Dec 10, 2019
dpgaspar
approved these changes
Dec 10, 2019
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CATEGORY
Choose one
SUMMARY
Small refactor to avoid circular dependency between superset config and superset package.
Current code doesn't support adding custom security manager as importing SupersetSecurityManager calls init.py that initializes the config.
TEST PLAN
REVIEWERS