[sqllab] Make sure null schema is None
and not "null"
#8255
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CATEGORY
Choose one
SUMMARY
A null schema in the request form is interpreted as the string
"null"
rather than actualnull
, resulting in/sql_json/
returning a response containing "null". This causes problems. These problems can be better explained by @john-bodley.Just a one line change to make sure
"null"
is translated into PythonNone
.TEST PLAN
Ran query locally that previously returned a
"null"
schema. Confirmed it is nownull
.REVIEWERS
@john-bodley @graceguo-supercat