[migration] make names non-nullable

[serenajiang]

CATEGORY

Choose one

• Bug Fix
• Enhancement (new features, refinement)
• Refactor
• Add tests
• Build / Development Environment
• Documentation

SUMMARY

Another try for #8332, which made dbs.database_name, clusters.cluster_name, and tables.table_name non-null to prevent __repr__ from ever returning None.

Tweaked to also make datasources.cluster_name non-nullable. It has a foreign key constraint with clusters.cluster_name and was breaking deploys.

TEST PLAN

Ran upgrade and downgrade, confirmed that the database schema looks as expected after each action.

Deployed. Confirmed does not break deploy.

ADDITIONAL INFORMATION

• Has associated issue:
• Changes UI
• Requires DB Migration.
• Confirm DB Migration upgrade and downgrade tested.
• Introduces new feature or API
• Removes existing feature or API

REVIEWERS

@etr2460 @john-bodley

[etr2460]

looks like ci is broken

[john-bodley]

I’m still somewhat perplexed as to why this was working before, i.e., how one could delete a cluster when there were associated datasources.

I think your logic seems sound. The Cypress tests were failing so I restarted them (they can be flakey at times).

[codecov-io]

Codecov Report

Merging #8371 into master will decrease coverage by 7.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #8371      +/-   ##
==========================================
- Coverage   67.57%   60.55%   -7.03%     
==========================================
  Files         448      332     -116     
  Lines       22527    10254   -12273     
  Branches     2364     2364              
==========================================
- Hits        15222     6209    -9013     
+ Misses       7167     3907    -3260     
  Partials      138      138

Impacted Files	Coverage Δ
superset/connectors/druid/__init__.py
superset/views/datasource.py
superset/models/sql_lab.py
superset/examples/helpers.py
superset/utils/import_datasource.py
superset/views/database/forms.py
superset/tasks/schedules.py
superset/db_engine_specs/bigquery.py
superset/examples/tabbed_dashboard.py
superset/db_engine_specs/athena.py
... and 103 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2117d1e...ce0b8cf. Read the comment docs.