Welcome page title: use app_name instead of 'Superset'

[Zanoellia]

CATEGORY

• Enhancement (new features, refinement)

SUMMARY

The title of the welcome page is a hard coded string (value: "Superset"). When setting the APP_NAME to a custom name, we expect to see this name for the page title.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

When changing the APP_NAME in superset/config.py file:

 # GLOBALS FOR APP Builder
 # ------------------------------
 # Uncomment to setup Your App name
-APP_NAME = "Superset"
+APP_NAME = "My Custom Name"

Before: the title of the welcome page is not updated (neither for pages without an explicit title)

After: the title is updated

[codecov-io]

Codecov Report

Merging #8427 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #8427   +/-   ##
=======================================
  Coverage   67.61%   67.61%           
=======================================
  Files         448      448           
  Lines       22486    22486           
  Branches     2364     2364           
=======================================
  Hits        15204    15204           
  Misses       7144     7144           
  Partials      138      138

Impacted Files	Coverage Δ
superset/views/core.py	71.38% <ø> (ø)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8f246ce...cc8902f. Read the comment docs.

[etr2460]

Looking at the template, I think if we don't specify a title here then it'll automatically fallback to appbuilder.app_name https://github.com/apache/incubator-superset/blob/71f1bbd2ec59b99d6ba6d9a4a2f9cfceaf922b80/superset/templates/superset/basic.html#L27

I think a better fix would be to not set the title attribute at all

[Zanoellia]

Sorry for the delay I miss the activity notification.

Thanks, your solution is more elegant indeed. I updated the code and tested locally 👌

[etr2460]

lgtm, thanks for the fix!