Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

explain the need to enable async queries #8444

Merged
merged 1 commit into from Oct 24, 2019
Merged

explain the need to enable async queries #8444

merged 1 commit into from Oct 24, 2019

Conversation

christophlingg
Copy link
Contributor

@christophlingg christophlingg commented Oct 24, 2019 •
edited

CATEGORY

Choose one

  • Bug Fix
  • Enhancement (new features, refinement)
  • Refactor
  • Add tests
  • Build / Development Environment
  • Documentation

SUMMARY

It took my a while to understand that you need to check this setting in order to have long running queries in SQL Lab. That should make it clearer.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TEST PLAN

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

REVIEWERS

@codecov-io
Copy link

codecov-io commented Oct 24, 2019 •
edited

Codecov Report

Merging #8444 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #8444   +/-   ##
=======================================
  Coverage   67.61%   67.61%           
=======================================
  Files         448      448           
  Lines       22486    22486           
  Branches     2364     2364           
=======================================
  Hits        15204    15204           
  Misses       7144     7144           
  Partials      138      138

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 786d770...42cb3d5. Read the comment docs.

etr2460
etr2460 approved these changes Oct 24, 2019
View reviewed changes
Copy link
Member

@etr2460 etr2460 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks for contributing to documentation!

@etr2460 etr2460 merged commit a39c24e into apache:master Oct 24, 2019
graceguo-supercat pushed a commit that referenced this pull request Nov 13, 2019
@christophlingg
explain the need to enable async queries (#8444)
5c3897e
@dpgaspar dpgaspar added the v0.35 label Dec 20, 2019
villebro pushed a commit that referenced this pull request Jan 4, 2020
@christophlingg @villebro
explain the need to enable async queries (#8444)
ba8bb6b
@mistercrunch mistercrunch added 🍒 0.35.2 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.36.0 labels Feb 28, 2024
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
@christophlingg @villebro
explain the need to enable async queries (apache#8444)
4bcbfe0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@etr2460 etr2460 etr2460 approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS v0.35 🍒 0.35.2 🚢 0.36.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@christophlingg @codecov-io @etr2460 @mistercrunch @dpgaspar