[datasource editor] Only one click target for edit action #8495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kristw
reviewed
Nov 1, 2019
| title={datasource.name} | ||
| className="label label-default label-btn m-r-5" | ||
| bsSize="sm" | ||
| id="datasource_menu" |
There was a problem hiding this comment.
would be better to use className instead of id
There was a problem hiding this comment.
this id was from old code. i think it's required by react bootstrap:
https://react-bootstrap.github.io/components/dropdowns/#dropdown-button-props
kristw
reviewed
Nov 1, 2019
| padding-left: 8px; | ||
| padding-right: 8px; | ||
| } | ||
| #datasource_menu .caret { |
kristw
approved these changes
Nov 1, 2019
graceguo-supercat
force-pushed
the
gg-ClickDatasourceName
branch
from
97a644f
to
8ed17ce
Compare
Codecov Report
@@ Coverage Diff @@
## master #8495 +/- ##
==========================================
- Coverage 66.61% 66.61% -0.01%
==========================================
Files 449 449
Lines 22610 22609 -1
Branches 2367 2366 -1
==========================================
- Hits 15061 15060 -1
Misses 7411 7411
Partials 138 138
Continue to review full report at Codecov.
|
john-bodley
pushed a commit
to airbnb/superset-fork
that referenced
this pull request
Nov 2, 2019
(cherry picked from commit acad66d)
graceguo-supercat
pushed a commit
that referenced
this pull request
Nov 13, 2019
villebro
pushed a commit
that referenced
this pull request
Jan 4, 2020
mistercrunch
added
🍒 0.35.2
🏷️ bot
cccs-rc
pushed a commit
to CybercentreCanada/superset
that referenced
this pull request
Mar 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CATEGORY
Choose one
SUMMARY
Some of our users didn't know how to find all options for edit datasource, since they didn't realize the datasource name and caret are different label buttons.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before:
After:
TEST PLAN
ADDITIONAL INFORMATION
REVIEWERS
@michellethomas @etr2460 @john-bodley