Math.max(...array) considered harmful

[betodealmeida]

CATEGORY

Choose one

• Bug Fix
• Enhancement (new features, refinement)
• Refactor
• Add tests
• Build / Development Environment
• Documentation

SUMMARY

In <FilterableTable> we're computing the maximum value of an array using this code snippet:

max_value = Math.max(...some_array);

The problem is that if some_array is big this will trigger the error RangeError: Maximum call stack size exceeded, since the number of arguments passed to the function Math.max is too big.

I fixed it by using reduce instead.

TEST PLAN

Tested with a query that was failing, it now works.

ADDITIONAL INFORMATION

• Has associated issue:
• Changes UI
• Requires DB Migration.
• Confirm DB Migration upgrade and downgrade tested.
• Introduces new feature or API
• Removes existing feature or API

REVIEWERS

@khtruong

[codecov-io]

Codecov Report

Merging #8575 into master will increase coverage by 5.11%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #8575      +/-   ##
==========================================
+ Coverage    66.5%   71.62%   +5.11%     
==========================================
  Files         450      118     -332     
  Lines       23117    12587   -10530     
  Branches     2451        0    -2451     
==========================================
- Hits        15375     9016    -6359     
+ Misses       7593     3571    -4022     
+ Partials      149        0     -149

Impacted Files	Coverage Δ
superset/db_engine_specs/postgres.py	55.55% <0%> (-27.78%)	⬇️
...sets/src/explore/components/ExploreChartHeader.jsx
superset/assets/src/components/Checkbox.jsx
...perset/assets/src/dashboard/util/getEmptyLayout.js
...ts/src/dashboard/util/getComponentWidthFromDrop.js
.../assets/src/dashboard/reducers/dashboardFilters.js
...rc/explore/components/controls/AnnotationLayer.jsx
superset/assets/src/welcome/DashboardTable.jsx
...erset/assets/src/dashboard/util/injectCustomCss.js
...explore/components/controls/ColorPickerControl.jsx
... and 322 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 78f41b3...df02493. Read the comment docs.