fix: default missing values to zero on area chart #8678
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #8678 +/- ##
==========================================
+ Coverage 65.77% 65.77% +<.01%
==========================================
Files 482 482
Lines 23834 23836 +2
Branches 2594 2594
==========================================
+ Hits 15676 15678 +2
Misses 7985 7985
Partials 173 173
Continue to review full report at Codecov.
|
etr2460
approved these changes
Dec 2, 2019
villebro
added a commit
that referenced
this pull request
Jan 4, 2020
* Add fill_value to area chart pivot * Only fill for area chart * Linting
mistercrunch
added
🍒 0.35.2
🏷️ bot
cccs-rc
pushed a commit
to CybercentreCanada/superset
that referenced
this pull request
Mar 6, 2024
* Add fill_value to area chart pivot * Only fill for area chart * Linting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CATEGORY
Choose one
SUMMARY
Area chart currently fails to render properly if there are missing groupby values in the time series. This PR makes it possible to specify NULL handling behavior per NVD3 chart, and defaults values to zero for the Area chart. Note: other charts are left unchanged, as defaulting to zero is most likely not expected behavior for all charts (at least line charts).
BEFORE
AFTER
TEST PLAN
Visual inspection.
ADDITIONAL INFORMATION
REVIEWERS
@etr2460