[css] Bringing Bootswatch in line with external variables, and other CSS tweaks #8781
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rusackas
force-pushed
the
cleaning-bootswatch
branch
from
864e0a9
to
8da09b8
Compare
rusackas
changed the title
Codecov Report
@@ Coverage Diff @@
## master #8781 +/- ##
==========================================
+ Coverage 58.87% 58.97% +0.09%
==========================================
Files 359 359
Lines 11330 11333 +3
Branches 2784 2787 +3
==========================================
+ Hits 6671 6684 +13
+ Misses 4481 4471 -10
Partials 178 178
Continue to review full report at Codecov.
|
mistercrunch
approved these changes
Jan 13, 2020
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CATEGORY
Choose one
SUMMARY
Bootstap and Bootswatch (Cosmo theme) have a bunch of colors and things in them that have not yet been brought inline with the global styles. This PR will aim to address that.
This PR also does the following:
• Updates Toasts to use global status (success/info/warn/error) colors.
• Updates those global status colors to be consistent, compromising between the two values used in the Cosmo theme and elsewhere in the CSS codebase
• Bumps LESS loader, because it seemed to cause no harm and fixes webpack watch mode.
• Includes the Cosmo
variables.lessfile at the bottom of the mainvariables.lessfile, since it's now acting more like an extension of those global vars. It also lets us include only the main variables file in our components, reducing reliance on Cosmo in general.• Prettier-ing of
superset.lesswhich points out a hole in theclean-cssscript I'll address in another quick PR.• Expands the scope of CSS linting to include
/superset/stylesheetsand not just/sueperset/src• Fixes a CSS-based issue with the Adhoc Metric Title editor, where the height jumps when entering/exiting edit mode. This was causing the Save button to be finnicky, and Cypress tests to fail. When the mouse went down, the field would lose focus and disappear, shrinking the popover, and then when the mouse went up, it would no longer be over the Save button, thus the click wouldn't register. The height now remains consistent. Animations below.
• Fixes an issue where
eslintwas failing due to thenode_modulesfolder insuperset/assets/cypress_base(fyi @nytai ). Added**/node_modulesto.eslintignoreBEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
A few of the more significant/visible changes:
Before (using a "pink" color that's quite near the error/danger color):
After (using the 'info' color since this seems like, well, info):
Before (warning color that didn't match the Cosmo theme's warning color):
After (the middle ground color between the prior one and Cosmo's warning color):
Before (ad hoc metric title bar height changing)
After (ad hoc metric title bar height consistent)
ADDITIONAL INFORMATION
REVIEWERS
@mistercrunch