[sip-15] Displaying endpoints for all start/end time ranges #8817
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #8817 +/- ##
==========================================
- Coverage 65.84% 59.16% -6.69%
==========================================
Files 483 367 -116
Lines 24177 11679 -12498
Branches 2777 2862 +85
==========================================
- Hits 15920 6910 -9010
+ Misses 8079 4590 -3489
- Partials 178 179 +1
Continue to review full report at Codecov.
|
|
ping @etr2460 |
etr2460
approved these changes
Jan 15, 2020
| .map( | ||
| (v, idx) => | ||
| (v.replace('T00:00:00', '') || (idx === 0 ? '-∞' : '∞')) + | ||
| (endpoints && value.includes(SEPARATOR) |
There was a problem hiding this comment.
instead of using value.includes here, i think it's cleaner to use the 3rd argument for the callback in map and check if the length of the array is > 1. see details here: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/map
etr2460
reviewed
Jan 17, 2020
superset/assets/src/explore/components/controls/DateFilterControl.jsx
Outdated
Show resolved
Hide resolved
superset/assets/src/explore/components/controls/DateFilterControl.jsx
Outdated
Show resolved
Hide resolved
…rol.jsx Co-Authored-By: Erik Ritter <erik.ritter@airbnb.com>
…rol.jsx Co-Authored-By: Erik Ritter <erik.ritter@airbnb.com>
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CATEGORY
Choose one
SUMMARY
This PR adds the SIP-15 endpoints to all time ranges which include a start and/or end as not just those containing a timestamp. This helps to provide more transparency. Note the conditional logic has mostly been reverted to what was changed here.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
AFTER
TEST PLAN
CI and manual testing.
ADDITIONAL INFORMATION
REVIEWERS
to: @etr2460 @graceguo-supercat @michellethomas