[charts] New, REST API #8917
Merged
[charts] New, REST API #8917
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #8917 +/- ##
==========================================
+ Coverage 58.97% 59.15% +0.17%
==========================================
Files 359 367 +8
Lines 11333 11681 +348
Branches 2787 2863 +76
==========================================
+ Hits 6684 6910 +226
- Misses 4471 4592 +121
- Partials 178 179 +1
Continue to review full report at Codecov.
|
villebro
reviewed
Jan 4, 2020
superset/views/core.py
Outdated
Comment on lines
108
to
111
| from .chart import views as chart_views | ||
| from .dashboard import views as dash_views | ||
| from .dashboard.filters import DashboardFilter | ||
| from .database import views as in_views | ||
| from .utils import ( |
There was a problem hiding this comment.
Same here regarding absolute vs relative imports.
There was a problem hiding this comment.
Will make a separate PR to address all relative imports on views (non charts related)
willbarrett
reviewed
Jan 7, 2020
# Conflicts: # superset/views/core.py # superset/views/dashboard/api.py
craig-rueda
approved these changes
Jan 17, 2020
12 tasks
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CATEGORY
Choose one
SUMMARY
New charts REST API.
Models that implement a owners field and security.ADDITIONAL INFORMATION
REVIEWERS