Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Fix docstrings in superset/config.py #8931

Merged
merged 1 commit into from Jan 7, 2020

Conversation

moshthepitt
Copy link
Contributor

CATEGORY

Choose one

  • Bug Fix
  • Enhancement (new features, refinement)
  • Refactor
  • Add tests
  • Build / Development Environment
  • Documentation

SUMMARY

Fix docstrings in config.py, specifically:

  • Replace ldap with LDAP
  • Replace (username/password() with (username/password)

TEST PLAN

There is no test plan because no Python code is affected.

- Replace ldap with LDAP
- Replace `(username/password()` with `(username/password)`
@codecov-io
Copy link

Codecov Report

Merging #8931 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #8931   +/-   ##
=======================================
  Coverage   58.97%   58.97%           
=======================================
  Files         359      359           
  Lines       11333    11333           
  Branches     2787     2787           
=======================================
  Hits         6684     6684           
  Misses       4471     4471           
  Partials      178      178

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 93bcace...b2c3692. Read the comment docs.

@dpgaspar dpgaspar changed the title Fix docstrings in superset/config.py [docs] Fix docstrings in superset/config.py Jan 7, 2020
@dpgaspar
Copy link
Member

dpgaspar commented Jan 7, 2020

Thank you @moshthepitt

@dpgaspar dpgaspar merged commit 28563ad into apache:master Jan 7, 2020
@moshthepitt moshthepitt deleted the fix-docstrings branch January 7, 2020 14:37
@villebro villebro added the v0.36 label Jan 8, 2020
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.36.0 labels Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS v0.36 🚢 0.36.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants