Refactor sql editor autocomplete #8967
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etr2460
force-pushed
the
erik-ritter--sql-editor-autocomplete-refactor
branch
from
8f94016
to
142eef5
Compare
Codecov Report
@@ Coverage Diff @@
## master #8967 +/- ##
==========================================
+ Coverage 58.68% 58.69% +<.01%
==========================================
Files 362 363 +1
Lines 11415 11417 +2
Branches 2801 2801
==========================================
+ Hits 6699 6701 +2
Misses 4538 4538
Partials 178 178
Continue to review full report at Codecov.
|
mistercrunch
approved these changes
Jan 15, 2020
| import { SQL_KEYWORD_AUTOCOMPLETE_SCORE } from '../constants'; | ||
|
|
||
| const SQL_KEYWORDS = [ | ||
| 'SELECT', |
There was a problem hiding this comment.
[optional] could sort alphabetically
etr2460
force-pushed
the
erik-ritter--sql-editor-autocomplete-refactor
branch
from
142eef5
to
2887aa4
Compare
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CATEGORY
Choose one
SUMMARY
Moves constants into the constants file, the
sqlKeywordsarray into a separate util file that other components can import, make the util file use typescript, and remove the string splitting on|TEST PLAN
Ensure SQL keywords autocomplete in SQL Lab, the metric editor popover and the filter editor popover
ADDITIONAL INFORMATION
REVIEWERS
to: @graceguo-supercat @mistercrunch @willbarrett