[druid] Making scaning/refreshing Druid datasource view items optional #8995
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
YASSSS...LGTM |
etr2460
approved these changes
Jan 22, 2020
superset/config.py
Outdated
| DRUID_IS_ACTIVE = True | ||
|
|
||
| # If Druid is active whether to include the links to scan/refresh Druid datasources. | ||
| # This should be disable if you are trying to wean yourself off of the Druid NoSQL |
There was a problem hiding this comment.
sp nit: This should be disabled
superset/config.py
Outdated
| # If Druid is active whether to include the links to scan/refresh Druid datasources. | ||
| # This should be disable if you are trying to wean yourself off of the Druid NoSQL | ||
| # connector. | ||
| DRUID_METADATA_VIEW_LINKS = True |
There was a problem hiding this comment.
maybe DRUID_METADATA_LINKS_ENABLED?
There was a problem hiding this comment.
Agreed. The VIEW term related to FAB views but the way it reads it's misleading.
john-bodley
force-pushed
the
john-bodley--druid-optional-refresh
branch
from
4991c3a
to
b3c863d
Compare
john-bodley
force-pushed
the
john-bodley--druid-optional-refresh
branch
from
b3c863d
to
f6366bb
Compare
Codecov Report
@@ Coverage Diff @@
## master #8995 +/- ##
==========================================
- Coverage 59.16% 59.16% -0.01%
==========================================
Files 367 367
Lines 11679 11680 +1
Branches 2862 2863 +1
==========================================
Hits 6910 6910
- Misses 4590 4591 +1
Partials 179 179
Continue to review full report at Codecov.
|
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CATEGORY
Choose one
SUMMARY
Some deployments with charts backed by the legacy Druid NoSQL connector can't simply go cold turkey on fully disabling Druid however we would like to wean ourselves off of Druid starting by removing the option to scan for new or refresh the metadata of the Druid datasources. Note the later menu item is somewhat of a misnomer as it refreshes all Druid datasource from the source and not just those currently registered in Superset.
This PR adds a config option to simply remove the view items for scanning/refreshing Druid datasources.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
BEFORE
When
DRUID_IS_ACTIVE = True(non-default) andDRUID_METADATA_LINKS_ENABLED = True(default)AFTER
When
DRUID_IS_ACTIVE = True(non-default) andDRUID_METADATA_LINKS_ENABLED = False(non-default)TEST PLAN
CI and tested locally.
ADDITIONAL INFORMATION
REVIEWERS
to: @michellethomas @mistercrunch @willbarrett