[database] new, API table metadata #9002
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…table # Conflicts: # superset/views/database/api.py
dpgaspar
commented
Jan 23, 2020
superset/views/database/api.py
Outdated
| from superset.views.database.validators import sqlalchemy_uri_validator | ||
|
|
||
|
|
||
| def get_table_schema_info( |
There was a problem hiding this comment.
Not very happy with placing this here...
dpgaspar
changed the title
dpgaspar
changed the title
Codecov Report
@@ Coverage Diff @@
## master #9002 +/- ##
=======================================
Coverage 59.15% 59.15%
=======================================
Files 367 367
Lines 11686 11686
Branches 2866 2866
=======================================
Hits 6913 6913
Misses 4594 4594
Partials 179 179Continue to review full report at Codecov.
|
villebro
approved these changes
Jan 24, 2020
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CATEGORY
SUMMARY
Migrate
/table/<database_id>/<table_name>/<schema>/to/api/v1/database/<database_id>/table/<table_name>/<schema_name>/resource.Response spec from swagger UI:
ADDITIONAL INFORMATION
REVIEWERS