Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix][i18n] Enable Spanish #9010

Merged
merged 1 commit into from Jan 24, 2020
Merged

Conversation

serenajiang
Copy link
Contributor

CATEGORY

  • Bug Fix
  • Enhancement (new features, refinement)
  • Refactor
  • Add tests
  • Build / Development Environment
  • Documentation

SUMMARY

Spanish was added a year ago but was never actually enabled.

TEST PLAN

tested locally

REVIEWERS

@etr2460

@codecov-io
Copy link

Codecov Report

Merging #9010 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9010      +/-   ##
==========================================
- Coverage   59.16%   59.15%   -0.02%     
==========================================
  Files         367      367              
  Lines       11679    11682       +3     
  Branches     2862     2864       +2     
==========================================
  Hits         6910     6910              
- Misses       4590     4593       +3     
  Partials      179      179
Impacted Files Coverage Δ
.../assets/src/SqlLab/components/AceEditorWrapper.jsx 54.32% <0%> (-1.38%) ⬇️
...uperset/assets/src/SqlLab/components/ResultSet.jsx 77.55% <0%> (-0.8%) ⬇️
superset/assets/src/chart/chartAction.js 47.94% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e46ff23...fa9e829. Read the comment docs.

Copy link
Member

@etr2460 etr2460 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@etr2460 etr2460 merged commit f079b6d into apache:master Jan 24, 2020
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.36.0 labels Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 0.36.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants