[fix] Reverting metic logic from #8901

[john-bodley]

CATEGORY

Choose one

• Bug Fix
• Enhancement (new features, refinement)
• Refactor
• Add tests
• Build / Development Environment
• Documentation

SUMMARY

This PR reverts the metric cleanup logic defined in #8901 as the superset-ui currently defines the metrics in the form {"label": <name>} per here.

Given that the superset-ui build is currently broken (though is actively being worked on) it seems like reverting the so-called temporary logic probably makes the most sense for now.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TEST PLAN

ADDITIONAL INFORMATION

• Has associated issue:
• Changes UI
• Requires DB Migration.
• Confirm DB Migration upgrade and downgrade tested.
• Introduces new feature or API
• Removes existing feature or API

REVIEWERS

to: @etr2460 @villebro
cc: @williaster

[villebro]

Thanks for fixing this @john-bodley . I was not aware superset-ui is not compatible with utils.get_metric_name(). Short term this is probably the right action, but long term it would be great to ensure proper alignment between frontend and backend logic.

[john-bodley]

@villebro agreed. Ideally there should be some CI checks or offline end-to-end test suite which verifies consistency between these packages especially as we are going to lean on the superset-ui package for the frontend logic.

[williaster]

thanks @john-bodley ! would be curious to hear any thoughts you have on how best to add the end-to-end tests. perhaps if the API v2 gets fleshed out (I think there are plans in the works for this), it would be a good time to add cc @kristw