Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[routes] Re-adding FAB API routes for TableColumnInlineView #9036

Merged
merged 1 commit into from Jan 28, 2020
Merged

[routes] Re-adding FAB API routes for TableColumnInlineView #9036

merged 1 commit into from Jan 28, 2020

Conversation

john-bodley
Copy link
Member

@john-bodley john-bodley commented Jan 28, 2020 •
edited

CATEGORY

Choose one

  • Bug Fix
  • Enhancement (new features, refinement)
  • Refactor
  • Add tests
  • Build / Development Environment
  • Documentation

SUMMARY

Apologies in #9035 the API routes should have been added to TableColumnInlineView rather than TableModelView.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TEST PLAN

CI and verified that the correct route worked.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

REVIEWERS

to: @etr2460 @graceguo-supercat @michellethomas

graceguo-supercat
graceguo-supercat approved these changes Jan 28, 2020
View reviewed changes
Copy link

@graceguo-supercat graceguo-supercat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@john-bodley john-bodley merged commit 162f810 into master Jan 28, 2020
@john-bodley john-bodley deleted the john-bodley--fix-9035 branch January 28, 2020 21:49
john-bodley added a commit to airbnb/superset-fork that referenced this pull request Jan 28, 2020
@john-bodley
[routes] Re-adding FAB API routes for TableColumnInlineView (apache#9036
13ecaf6 
)

(cherry picked from commit 162f810)
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.36.0 labels Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@graceguo-supercat graceguo-supercat graceguo-supercat approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 0.36.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@john-bodley @graceguo-supercat @mistercrunch