Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] Adding show to FAB CRUD set #9040

Merged
merged 1 commit into from Jan 29, 2020

Conversation

john-bodley
Copy link
Member

@john-bodley john-bodley commented Jan 29, 2020

CATEGORY

Choose one

  • Bug Fix
  • Enhancement (new features, refinement)
  • Refactor
  • Add tests
  • Build / Development Environment
  • Documentation

SUMMARY

Fixes #9039.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

BEFORE

Screen Shot 2020-01-28 at 4 41 56 PM

AFTER

Screen Shot 2020-01-28 at 4 42 19 PM

TEST PLAN

Tested locally.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

REVIEWERS

to: @etr2460 @mistercrunch @nytai

@codecov-io
Copy link

Codecov Report

Merging #9040 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #9040   +/-   ##
=======================================
  Coverage   59.43%   59.43%           
=======================================
  Files         369      369           
  Lines       11743    11743           
  Branches     2884     2884           
=======================================
  Hits         6980     6980           
  Misses       4584     4584           
  Partials      179      179

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2fc3d84...ccacd36. Read the comment docs.

Copy link
Member

@nytai nytai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@john-bodley john-bodley merged commit a303c3c into apache:master Jan 29, 2020
@john-bodley john-bodley deleted the john-bodley--issue-9039 branch January 29, 2020 01:19
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.36.0 labels Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 0.36.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

View Icon gone from Chart, Table, Dashboard CRUD Views
4 participants