Add support for Cockroach DB #9043
Conversation
requirements-dev.txt
Outdated
| @@ -16,6 +16,7 @@ | |||
| # | |||
| black==19.3b0 | |||
| coverage==4.5.3 | |||
| cockroachdb==0.3.3 | |||
There was a problem hiding this comment.
This needs to be moved to extras_require in setup.py.
| from datetime import datetime | ||
| from typing import List, Optional, Tuple, TYPE_CHECKING | ||
|
|
||
| from pytz import _FixedOffset # type: ignore | ||
| from sqlalchemy.dialects.postgresql.base import PGInspector | ||
|
|
||
| from superset.db_engine_specs.base import LimitMethod | ||
| from superset.db_engine_specs.postgres import PostgresEngineSpec | ||
|
|
||
| if TYPE_CHECKING: | ||
| # prevent circular imports | ||
| from superset.models.core import Database # pylint: disable=unused-import |
There was a problem hiding this comment.
You seem to be importing lots of things that aren't being used in this file. If you check CI logs you will see that this is failing builds.
Codecov Report
@@ Coverage Diff @@
## master #9043 +/- ##
==========================================
+ Coverage 59.43% 59.45% +0.01%
==========================================
Files 369 369
Lines 11743 11747 +4
Branches 2884 2888 +4
==========================================
+ Hits 6980 6984 +4
Misses 4584 4584
Partials 179 179
Continue to review full report at Codecov.
|
|
@derari thanks a lot for your work on this! I tried to apply the changes in this PR manually, and it didn't work OOTB with docker-compose. It seems like adding the cockroach dep to This is first contact with superset for me, so forgive me if this comment is incorrect or misguided! |
mistercrunch
added
🏷️ bot
CATEGORY
Choose one
SUMMARY
Adds support for Cockroach DB.
I could not test the change becaues the container always fails with
but this seems unrelated to my change.
So far I could use Cockroach DB in superset even without explicit support, only the time grain options were missing.
I verified that the time grain options declared by PostgresEngineSpec work with Cockroach DB.
TEST PLAN
Add a Cockroach DB datasource, add tables and test charts.
ADDITIONAL INFORMATION
REVIEWERS