Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SQL Lab] Remove space after schema autocomplete #9059

Merged

Conversation

etr2460
Copy link
Member

@etr2460 etr2460 commented Jan 31, 2020

CATEGORY

Choose one

  • Bug Fix
  • Enhancement (new features, refinement)
  • Refactor
  • Add tests
  • Build / Development Environment
  • Documentation

SUMMARY

Schemas almost always are followed by a . and not a space, so let's not add a space when autocompleting

TEST PLAN

Ensure schemas and functions don't get spaces added after them when autocompleting, but all other words (table names, sql keywords, etc.) do

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

REVIEWERS

@john-bodley @betodealmeida @graceguo-supercat

@codecov-io
Copy link

Codecov Report

Merging #9059 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #9059   +/-   ##
=======================================
  Coverage   59.45%   59.45%           
=======================================
  Files         369      369           
  Lines       11747    11747           
  Branches     2888     2888           
=======================================
  Hits         6984     6984           
  Misses       4584     4584           
  Partials      179      179
Impacted Files Coverage Δ
.../assets/src/SqlLab/components/AceEditorWrapper.jsx 54.21% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2629c77...1870cf9. Read the comment docs.

@etr2460 etr2460 merged commit 47eecb8 into apache:master Jan 31, 2020
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.36.0 labels Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 0.36.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants